Only use ci-friendly version if there is such property defined #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
laeubi
force-pushed
the
only_use_ci_firendly_when_in_model
branch
from
2b9de3a to
70dd0da
Compare
tivervac
reviewed
Jan 5, 2024
tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/AbstractTychoMapping.java
Show resolved
Hide resolved
tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/AbstractTychoMapping.java
Show resolved
Hide resolved
tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/AbstractTychoMapping.java
Outdated
Show resolved
Hide resolved
tycho-extras/tycho-pomless/src/main/java/org/eclipse/tycho/pomless/AbstractTychoMapping.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
only_use_ci_firendly_when_in_model
branch
from
70dd0da to
9352449
Compare
tivervac
approved these changes
Jan 5, 2024
Currently it can happen that one uses one of the "trigger properties" that enable Tycho pomless feature to assume that a cifriendly version is to be used even though ci-friendly versions are actually not used at all. This tries to differentiate the two cases by checking if there is actually a property defined that could be used in a ci-friendly way.
laeubi
force-pushed
the
only_use_ci_firendly_when_in_model
branch
from
9352449 to
fc0c09b
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
laeubi
added
the
sponsored
|
This bugfix was gently sponsored by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it can happen that one uses one of the "trigger properties" that enable Tycho pomless feature to assume that a cifriendly version is to be used even though ci-friendly versions are actually not used at all.
This tries to differentiate the two cases by checking if there is actually a property defined that could be used in a ci-friendly way.